Merged
Conversation
rohanInsticator
requested changes
Jun 27, 2024
rohanInsticator
left a comment
There was a problem hiding this comment.
- The latest PrebidJS change of publisherId is not there.
- I don't see any code related to Content Object.
- IP & UA logic we discussed is still missing.
- I don't see any logic related to setting our UserId
- If a publisher is trying to pass us device or geo objects, they are also not here.
Author
|
Here is initial request payload from postman: Here's is entire curl request with headers, ua and other: |
Author
|
Here's is BidRequest received at the exchange in the ORTB controller. |
Author
|
Here is the final response of the prebid-server of the same request. Note, I have debug mode enabled in the prebid-server. Therefore, the response has a debug field which determines the steps it went through. |
Author
|
Here's request PBjs is sending to prebid-server: |
shubhamc-ins
added a commit
that referenced
this pull request
Jul 10, 2024
* init insticator adaptor * update modules * add mediaType for bids * update insticator adaptor with tests * update insticator for test cases * fix test cases * update InstAdapter * update insticator adaptor * fix test cases for adUnitId * update insticator adapter type * Updates - add currency converter support - Add video validation support * remove default plcmt and placement * add more test cases * update for publisher ID * fix tests
shubhamc-ins
pushed a commit
that referenced
this pull request
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.