Fixes to network refactoring#11
Merged
IntelOrca merged 1 commit intoIntelOrca:refactor/networkfrom May 28, 2016
Merged
Conversation
Collaborator
Author
|
still fails for mingw, let me fix that |
janisozaur
force-pushed
the
network-refactor
branch
from
4bc67ac to
0193822
Compare
Collaborator
Author
|
should be good now |
Owner
|
thanks |
src/network/NetworkTypes.h
Outdated
|
|
||
| #include <SDL_endian.h> | ||
| #include <SDL_platform.h> | ||
| #include "../common.h" |
Owner
There was a problem hiding this comment.
You can't do this, because winsock2 includes windows.h and that has to go before common.h. Its silly, I wish we didn't put windows.h in any header files, but because the network structures are needed in the headers, winsock2 is needed including windows.h.
Collaborator
Author
There was a problem hiding this comment.
If you leave it afterwards, FASTCALL is redefined.
Owner
There was a problem hiding this comment.
doesn't that mean common.h needs to not redefine it if its already defined?
janisozaur
force-pushed
the
network-refactor
branch
from
0193822 to
46d225d
Compare
Collaborator
Author
|
updated |
IntelOrca
pushed a commit
that referenced
this pull request
May 29, 2016
IntelOrca
pushed a commit
that referenced
this pull request
May 30, 2016
IntelOrca
added a commit
that referenced
this pull request
Jun 8, 2016
IntelOrca
pushed a commit
that referenced
this pull request
Mar 10, 2018
While looking at OpenRCT2#7176 (comment) I got a crash with stacktrace: OpenRCT2#0 0x7f9e81fa2e30 in object_entry_get_entry(int, unsigned long) ../src/openrct2/object/ObjectList.cpp:181 #1 0x7f9e81fa24ae in get_loaded_object_entry(unsigned long) ../src/openrct2/object/ObjectList.cpp:142 #2 0x7f9e8215d64f in S6Exporter::Export() ../src/openrct2/rct2/S6Exporter.cpp:169 #3 0x7f9e8216de71 in scenario_save(char const*, int) ../src/openrct2/rct2/S6Exporter.cpp:757 #4 0x7f9e81c932b0 in game_autosave() ../src/openrct2/Game.cpp:1590 #5 0x7f9e828625b6 in scenario_autosave_check() ../src/openrct2/scenario/Scenario.cpp:297 #6 0x7f9e81c8a958 in game_update() ../src/openrct2/Game.cpp:439 #7 0x7f9e81c6731f in OpenRCT2::Context::Update() (/home/janisozaur/workspace/OpenRCT2/build/libopenrct2.so+0x10f331f) #8 0x7f9e81c6674c in OpenRCT2::Context::RunVariableFrame() (/home/janisozaur/workspace/OpenRCT2/build/libopenrct2.so+0x10f274c) #9 0x7f9e81c6402d in OpenRCT2::Context::RunFrame() (/home/janisozaur/workspace/OpenRCT2/build/libopenrct2.so+0x10f002d) #10 0x7f9e81c638f4 in OpenRCT2::Context::RunGameLoop() (/home/janisozaur/workspace/OpenRCT2/build/libopenrct2.so+0x10ef8f4) #11 0x7f9e81c627bf in OpenRCT2::Context::Launch() (/home/janisozaur/workspace/OpenRCT2/build/libopenrct2.so+0x10ee7bf) #12 0x7f9e81c5b08a in OpenRCT2::Context::RunOpenRCT2(int, char const**) ../src/openrct2/Context.cpp:170 #13 0x56323695b95e in main ../src/openrct2-ui/Ui.cpp:60 Sadly I cannot reproduce it anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.