-
Notifications
You must be signed in to change notification settings - Fork 38
Fixed issue 14 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue 14 #17
Conversation
1. Use `pthread_atfork` to restore MKL threading layer environment variable set by init code for the forked process. 2. Fixed multiple GCC compiler warnings.
1. Remove use of six, and remove mention of its requirement in setup 2. No longer attempt to infer MKL location from numpy's distutils Always require MKLROOT variable to be set.
Added Cython directives for language_level=2
anton-malakhov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @oleksandr-pavlyk! |
|
It would be good to know when this makes its way into conda |
|
Yes, I was thinking of releasing 2.4.0 today. I am looking through new functionality in MKL to add to service.
Also adding support for more code in |
|
@rgommers Fixed build break in conda-forge/mkl-service-feedstock#17 |
|
thanks! |
Used
pthread_atforkto restore environment variableMKL_THREADING_LAYERfor the forked process.@peterbell10 @rgommers
Closes #14
Using the environment as specified in #14, and
With this fix I am getting: