Remove proto-lens SRP#1185
Conversation
carbolymer
requested review from
a team,
CarlosLopezDeLara,
Jimbo4350,
disassembler,
erikd and
palas
as code owners
There was a problem hiding this comment.
Pull request overview
Removes the proto-lens source-repository-package pin from cabal.project so builds can rely on the package index instead of a git checkout, alongside dependency/index-state updates to support that shift.
Changes:
- Update
cabal.projectindex-states and remove the conditionalproto-lensSRP stanza. - Bump
cardano-rpc’sproto-lenslower bound to>= 0.7.1.7. - Refresh Nix flake inputs in
flake.lock(CHaP + hackage.nix).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
flake.lock |
Updates locked revisions/hashes for CHaP and hackage.nix inputs. |
cardano-rpc/cardano-rpc.cabal |
Raises proto-lens lower bound to align with dropping the SRP pin. |
cabal.project |
Advances index-state and removes the proto-lens SRP stanza. |
carbolymer
force-pushed
the
mgalazyn/chore/remove-prot-lens-srp
branch
3 times, most recently
from
1b0a556 to
87a2920
Compare
carbolymer
force-pushed
the
mgalazyn/chore/remove-prot-lens-srp
branch
from
87a2920 to
73da39d
Compare
| project: cardano-rpc | ||
| pr: 1185 | ||
| kind: | ||
| - maintenance |
There was a problem hiding this comment.
This fragment is marked as maintenance, but it changes the public build constraints of cardano-rpc (bumps the proto-lens lower bound). Similar dependency-bound changes in this repo have been categorized as compatible (e.g. .changes/20260409_cardano_rpc_proto_lens_lower_bound.yml). Consider using compatible here so release notes reflect that downstream build plans may need updating.
| - maintenance | |
| - compatible |
There was a problem hiding this comment.
Two small things beyond what Copilot flagged.
cardano-api/cardano-api.cabal:339 (not in the diff, flagging here): the main library bound was bumped to cardano-ledger-core >=1.20, but the test-suite's cardano-ledger-core:{cardano-ledger-core, testlib} >=1.17 is now stale. Cabal resolves to >=1.20 via the library constraint so it builds, but the bound here is misleading. Worth bumping to >=1.20 for consistency.
| # buf version must match `.github/workflows/haskell.yml` (buf is | ||
| # not backwards-compatible across minor versions for | ||
| # `buf generate` output). | ||
| unstable.buf |
There was a problem hiding this comment.
unstable.buf doesn't actually pin a version. inputs.unstable.url = "nixpkgs/nixos-unstable" is locked by flake.lock today, so it's deterministic for this checkout but the next nix flake update can silently move buf off v1.66.1 and reintroduce the exact drift this PR is trying to fix. The comment above asserts alignment with CI but nothing enforces it. Could we fetch the pinned binary the same way CI does (or otherwise derive both versions from a single source of truth)?
There was a problem hiding this comment.
the next nix flake update can silently move buf off v1.66.1 and reintroduce the exact drift this PR is trying to fix.
This is fine in my opinion, as flake update is a thing we can control. I'll do the opposite and implement the check using buf from nixpkgs.
There was a problem hiding this comment.
I've split buf generate into separate job - that should speed up GHA since it'll run in parallel. It'll also use the same buf as nix development shell, so it'll be pinned to a version from nixpkgs.
carbolymer
force-pushed
the
mgalazyn/chore/remove-prot-lens-srp
branch
3 times, most recently
from
3ebf81f to
05cd63b
Compare
carbolymer
force-pushed
the
mgalazyn/chore/remove-prot-lens-srp
branch
from
05cd63b to
7b1aaf7
Compare
Context
Remove proto-lens SRP. Fix buf version drift.
Fix: #1184
Checklist
.changes/