Merged
Conversation
denisshevchenko
force-pushed
the
trace-node-state
branch
from
c736338 to
058a670
Compare
denisshevchenko
requested review from
DavidEichmann,
JaredCorduan,
Jimbo4350,
dcoutts,
deepfire,
erikd,
jutaro,
nc6 and
newhoggy
as code owners
denisshevchenko
force-pushed
the
trace-node-state
branch
2 times, most recently
from
d4cd333 to
d3fea80
Compare
iohk-bors bot
added a commit
that referenced
this pull request
Feb 16, 2022
3591: Trace NodeState: demo r=deepfire a=denisshevchenko This is the first step toward `NodeState` tracing. The `NodeState` represents the current state of the node. So any external application (for example, `cardano-wallet` or `cardano-tracer`) will be able to ask this state (as a `DataPoint`) and use it. Currently, `NodeState` is almost useless, it only demonstrates the changing the state of a node in real-time. This PR introduces `demo-acceptor` as well: a tiny application allowing to ask `DataPoint` from the node. Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from DavidEichmann, JaredCorduan, Jimbo4350, dcoutts, erikd, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Jimbo4350
reviewed
Feb 16, 2022
Contributor
Jimbo4350
left a comment
Jimbo4350
left a comment
There was a problem hiding this comment.
Can we also squash the first two commits?
cardano-tracer: seq tests, disable some log tests for Windows.
denisshevchenko
force-pushed
the
trace-node-state
branch
from
d3fea80 to
6edce0c
Compare
Contributor
Author
|
@Jimbo4350 Done, now there are only 2 commits. |
nc6
approved these changes
Feb 17, 2022
Contributor
|
bors merge |
Contributor
|
Build succeeded: |
This was referenced Feb 24, 2022
iohk-bors bot
added a commit
that referenced
this pull request
Mar 15, 2022
3656: cardano-node-3644: node state ADT expand. r=deepfire a=denisshevchenko As a result of #3591, we now have a new `DataPoint` called `NodeState`. An external application (for example, `cardano-wallet`) can ask for this `DataPoint` to know the current state of the node. Initially, `NodeState` was a primitive ADT and contained a very small portion of information. Now it's expanded. Also, this PR moved node's peers info in a separate `DataPoint`. The documentation is at: https://github.com/input-output-hk/cardano-node/wiki/cardano-node-and-DataPoints:-demo 3707: Workbench: make geneses effectively cacheable in CI, by pinning the producing workbench r=deepfire a=deepfire This makes workbench-produced geneses effectively cacheable in CI, by pinning the producing workbench as a new flake input. Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io> Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
iohk-bors bot
added a commit
that referenced
this pull request
Mar 15, 2022
3656: cardano-node-3644: node state ADT expand. r=deepfire a=denisshevchenko As a result of #3591, we now have a new `DataPoint` called `NodeState`. An external application (for example, `cardano-wallet`) can ask for this `DataPoint` to know the current state of the node. Initially, `NodeState` was a primitive ADT and contained a very small portion of information. Now it's expanded. Also, this PR moved node's peers info in a separate `DataPoint`. The documentation is at: https://github.com/input-output-hk/cardano-node/wiki/cardano-node-and-DataPoints:-demo Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
iohk-bors bot
added a commit
that referenced
this pull request
Mar 16, 2022
3656: cardano-node-3644: node state ADT expand. r=deepfire a=denisshevchenko As a result of #3591, we now have a new `DataPoint` called `NodeState`. An external application (for example, `cardano-wallet`) can ask for this `DataPoint` to know the current state of the node. Initially, `NodeState` was a primitive ADT and contained a very small portion of information. Now it's expanded. Also, this PR moved node's peers info in a separate `DataPoint`. The documentation is at: https://github.com/input-output-hk/cardano-node/wiki/cardano-node-and-DataPoints:-demo Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step toward
NodeStatetracing. TheNodeStaterepresents the current state of the node. So any external application (for example,cardano-walletorcardano-tracer) will be able to ask this state (as aDataPoint) and use it.Currently,
NodeStateis almost useless, it only demonstrates the changing the state of a node in real-time.This PR introduces
demo-acceptoras well: a tiny application allowing to askDataPointfrom the node.