Allow assembling transactions with no witnesses#4408
Conversation
6bb6447 to
c494863
Compare
There was a problem hiding this comment.
@LudvikGalois have you confirmed this works on a local testnet?
I've tested that it works in so far as the command in the ticket works and you can assemble the transaction. I didn't check if it was actually a useful thing to do, and it seems like it's not, since it's impossible to submit that transaction. I'm not even sure how to redeem from a SimpleScript - the docs are out of date. |
c494863 to
1e355da
Compare
I have now confirmed that this allows spending of transactions from script addresses containing a script that requires no signatures. |
1e355da to
9b0605a
Compare
Jimbo4350
left a comment
There was a problem hiding this comment.
LGTM, QA approval needed
|
This PR is stale because it has been open 45 days with no activity. |
9b0605a to
442b357
Compare
9f7dd3c to
62f99cd
Compare
It's possible to write a script which requires no signatures, for
example
```
{
"scripts": [
{
"keyHash": "df243ee05bbe556970c9f8b48088b90549b8c9e41a3380fdede62d16",
"type": "sig"
},
{
"keyHash": "452c6cc84a5430b4ff720d5692e0ce7f4d37b1f78a3bea99fdbab240",
"type": "sig"
},
{
"keyHash": "9b925a6b6462e0c7c48fc69a06d1e72d03da30655fd5af40e988140e",
"type": "sig"
}
],
"type": "atLeast",
"required": 0
}
```
As such, it should be supported by the CLI to assemble a transaction
with no witnesses. Both the assemble and sign commands have been updated
to support this.
Fixes: #3835
62f99cd to
faa52ab
Compare
It's possible to write a script which requires no signatures, for
example
As such, it should be supported by the CLI to assemble a transaction
with no witnesses.
Fixes: #3835
Closes: #4471