🐛 search doesn't work on outcomes

[m-i-k-e]

Area

Other

Domain

preview.gov.tools

Which wallet were you using?

no wallet

Context

I was testing the search: see Video: https://www.loom.com/share/a167a5eb1b424f80920e487e0a8666f6?sid=b349fc9f-5186-422f-a101-10f70148d0fd

Steps to reproduce

Go to outcomes
search for something

Actual behavior

You don't get any results

Expected behavior

You find what your searching for

[kneerose]

@m-i-k-e , @profd2004 , As I understand, the search for outcomes relies on the title fetched from DBSync. If a proposal's title is not set in dbsync due to restrictions but has a valid URL and hash, the search fails in such cases.
CC: @bosko-m

[m-i-k-e]

@bosko-m Has this been fixed?

[m-i-k-e]

@kneerose Your comment just says why it doesn't work. It is still a bug. Users will expect search to 'search'

[bosko-m]

@m-i-k-e This has nothing to do with Outcomes or GovTool. Search based on DBSync does work.
Can you list down which examples didnt produce search results?

[kneerose]

@m-i-k-e, yes, it can still be considered as a bug. The proposal title is displayed based on the metadata URL provided, which may not be in DBSync. In such cases, the search functionality fails. However, since the outcomes title is displayed using the metadata details, the search should use the metadata details title as well.

For example:

1. A title set in DBSync works with search:
   https://preview.gov.tools/outcomes?sort=oldestFirst&q=Buy+Ryan+a+island

2. A title not set in dbsync but matched with the metadata URL and hash:
   https://preview.gov.tools/outcomes?sort=oldestFirst&q=19a065f3262b44d2cc8289dd7729b2e4078418642b857b996176760adc9f87e2%230

For this proposal, searching by the title "Let's Hardfork Out of Bootstrapping!!" does not work.
CC: @bosko-m