Skip to content

feat(#2686): add share button to every DRep#2689

Merged
MSzalowski merged 1 commit into
developfrom
fix/2686-share-button-is-missing-from-the-dreps-details-page
Jan 22, 2025
Merged

feat(#2686): add share button to every DRep#2689
MSzalowski merged 1 commit into
developfrom
fix/2686-share-button-is-missing-from-the-dreps-details-page

Conversation

@MSzalowski
Copy link
Copy Markdown
Contributor

List of changes

  • Previously share DRep button was visible only for our own registered DRep, this PR introduces this button for every DRep detail page

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Jan 22, 2025 that may be closed by this pull request
@MSzalowski MSzalowski marked this pull request as ready for review January 22, 2025 14:40
@MSzalowski MSzalowski requested a review from placek January 22, 2025 14:40
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@MSzalowski MSzalowski merged commit 93c34f7 into develop Jan 22, 2025
@MSzalowski MSzalowski deleted the fix/2686-share-button-is-missing-from-the-dreps-details-page branch January 22, 2025 19:39
@github-actions
Copy link
Copy Markdown
Contributor

@MSzalowski
This PR is in the tag: develop-93c34f79fd81a9eb569a6b164b4a639b04e2db1a , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@MSzalowski
This PR is in the tag: develop-93c34f79fd81a9eb569a6b164b4a639b04e2db1a , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

@MSzalowski
This PR is in the tag: develop-93c34f79fd81a9eb569a6b164b4a639b04e2db1a , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Share button is missing from the DReps details page

2 participants