Skip to content

fix(#1841): fix unhandled missing index exception #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MSzalowski merged 1 commit into from
Jan 30, 2025
Merged

fix(#1841): fix unhandled missing index exception #2836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ changes.
### Fixed

- Fix displaying DRep with doNotList property as string
- Handle exception when no index is provided to /proposal/get endpoint [Issue 1841](https://github.com/IntersectMBO/govtool/issues/1841)

### Changed

Expand Down
13 changes: 8 additions & 5 deletions govtool/backend/src/VVA/API/Types.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,14 @@ instance ToJSON GovActionId where
instance FromHttpApiData GovActionId where
parseUrlPiece t = case Text.splitOn "#" t of
[hash, rest] -> do
index <- case readMaybe $ Text.unpack rest of
Just x -> pure x
_ -> Left (Text.tail rest <> " is not a number")
hexHash <- parseUrlPiece hash
Right $ GovActionId hexHash index
if Text.null rest
then Left "Missing index in hash#index format"
else do
index <- case readMaybe $ Text.unpack rest of
Just x -> pure x
_ -> Left (rest <> " is not a number")
hexHash <- parseUrlPiece hash
Right $ GovActionId hexHash index
_ -> Left "Not a valid hash#index value"

exampleGovActionId :: Text
Expand Down