Skip to content

Fix: governance action ada format , vote context char limit and change poll vote#2910

Merged
kneerose merged 5 commits into
developfrom
fix/govAction-adaFormat-voteContext-charLimit
Feb 6, 2025
Merged

Fix: governance action ada format , vote context char limit and change poll vote#2910
kneerose merged 5 commits into
developfrom
fix/govAction-adaFormat-voteContext-charLimit

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented Feb 5, 2025

List of changes

  • Update governance action ada format
  • Add not voted assertion for dRep
  • Update vote context char limit validation
  • fix change poll vote flaky test issue
  • increase timeout for reply and poll vote assertion

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2025

✅ All checks succeeded

@kneerose kneerose changed the title Fix: governance action ada format and vote context char limit Fix: governance action ada format , vote context char limit and change poll vote Feb 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2025

✅ All checks succeeded

@kneerose kneerose merged commit de6165f into develop Feb 6, 2025
@kneerose kneerose deleted the fix/govAction-adaFormat-voteContext-charLimit branch February 6, 2025 04:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2025

@kneerose
This PR is in the tag: develop-de6165fbb86ea1dd6960fed3a8b7f5da191be1d4 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2025

@kneerose
This PR is in the tag: develop-de6165fbb86ea1dd6960fed3a8b7f5da191be1d4 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2025

@kneerose
This PR is in the tag: develop-de6165fbb86ea1dd6960fed3a8b7f5da191be1d4 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants