Skip to content

Tests: constitution type proposal#2970

Merged
mesudip merged 10 commits into
developfrom
tests/constitution-type-proposal
Feb 13, 2025
Merged

Tests: constitution type proposal#2970
mesudip merged 10 commits into
developfrom
tests/constitution-type-proposal

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented Feb 13, 2025

List of changes

  • Fix previous proposal test due to updates on proposal type test ids
  • Rename skipIfTreasuryAndBootstrapping to skipIfNotInfoAndBootstrapping and reject all proposal type than info on bootstrap
  • Support validation, visibility and submission tests to update the constitutional type proposal

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

Copy link
Copy Markdown
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mesudip mesudip merged commit 16be6c9 into develop Feb 13, 2025
@mesudip mesudip deleted the tests/constitution-type-proposal branch February 13, 2025 12:11
@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-16be6c9835e05e8e654ece028e78ce43e179e89b , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-16be6c9835e05e8e654ece028e78ce43e179e89b , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-16be6c9835e05e8e654ece028e78ce43e179e89b , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants