Skip to content

Fix: report 315 failing tests#3004

Merged
kneerose merged 7 commits into
developfrom
fix/report-315-failing-tests
Feb 17, 2025
Merged

Fix: report 315 failing tests#3004
kneerose merged 7 commits into
developfrom
fix/report-315-failing-tests

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

List of changes

  • Fix total dRep abstain vote calculation
  • Remove total dRepNotVoted assertion due to confusion on the calculation
  • Remove unnecessary proposal mock file for show-all proposal type test

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose kneerose merged commit 3073c1d into develop Feb 17, 2025
@kneerose kneerose deleted the fix/report-315-failing-tests branch February 17, 2025 10:26
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-3073c1ddb5597224f052bbdeea1bf7d1f4008748 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-3073c1ddb5597224f052bbdeea1bf7d1f4008748 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-3073c1ddb5597224f052bbdeea1bf7d1f4008748 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants