Skip to content

feat: inject error logs on all test#3044

Merged
mesudip merged 14 commits into
developfrom
feat/log-inject
Feb 21, 2025
Merged

feat: inject error logs on all test#3044
mesudip merged 14 commits into
developfrom
feat/log-inject

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented Feb 20, 2025

List of changes

  • Inject errors console logs on logger report
  • Remove unnecessary failureWithConsoleMessages function
  • Increase timeout of voting power and vote status
  • Add some timeouts after the search text is filled on the proposal
  • Fix delegated ada format
  • Fix dRep filter issue
  • Refactor proposal test
  • Wrap kuber get service with functionWaitedAssert

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from MSzalowski as a code owner February 20, 2025 10:56
@kneerose kneerose requested a review from mesudip February 20, 2025 10:56
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose kneerose requested a review from Ryun1 as a code owner February 21, 2025 09:40
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

Copy link
Copy Markdown
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mesudip mesudip merged commit bb36959 into develop Feb 21, 2025
@mesudip mesudip deleted the feat/log-inject branch February 21, 2025 09:48
@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-bb36959bb55b461bc4a197407c2e2ac88641e36e , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-bb36959bb55b461bc4a197407c2e2ac88641e36e , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-bb36959bb55b461bc4a197407c2e2ac88641e36e , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants