Skip to content

Bugfix: remaining failing test#3059

Merged
kneerose merged 8 commits into
developfrom
bugfix/remaining-failing-test
Feb 24, 2025
Merged

Bugfix: remaining failing test#3059
kneerose merged 8 commits into
developfrom
bugfix/remaining-failing-test

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

List of changes

  • Increase assertion timeout to 1 min
  • Wrap validation and visibility test with assertion function for retries to 1mins
  • Add message for failing assertion of proposal and dRep visibility and validation
  • Write proposalParameter to file and get parameter from file instead of fetch on each test

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

Copy link
Copy Markdown
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kneerose kneerose merged commit 716d9f4 into develop Feb 24, 2025
@kneerose kneerose deleted the bugfix/remaining-failing-test branch February 24, 2025 08:36
@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-716d9f4ab98514a44c4c9f4a38c23b338e5e695f , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-716d9f4ab98514a44c4c9f4a38c23b338e5e695f , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-716d9f4ab98514a44c4c9f4a38c23b338e5e695f , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants