Skip to content

fix: remove unnecessary filter in fetchFirstActiveDRepDetails ,add scroll to page and show correct message in revote "5E" test#3072

Merged
kneerose merged 2 commits into
developfrom
bugfix/fetch-active-dRep
Feb 25, 2025
Merged

fix: remove unnecessary filter in fetchFirstActiveDRepDetails ,add scroll to page and show correct message in revote "5E" test#3072
kneerose merged 2 commits into
developfrom
bugfix/fetch-active-dRep

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented Feb 25, 2025

List of changes

  • Remove redundant filter in fetchFirstActiveDRepDetails, as the active filter is applied by default
  • As it unchecked the active filter and fetch random dRep instead of active dRep
  • Add scroll to the page for a proper screenshot for vote status
  • Add proper status message for revote 5E test

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from MSzalowski as a code owner February 25, 2025 06:27
@kneerose kneerose requested a review from mesudip February 25, 2025 06:27
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose kneerose changed the title fix: remove unnecessary filter in fetchFirstActiveDRepDetails fix: remove unnecessary filter in fetchFirstActiveDRepDetails ,add scroll to page and show correct message in revote "5E" test Feb 25, 2025
@kneerose kneerose merged commit d50e2f5 into develop Feb 25, 2025
@kneerose kneerose deleted the bugfix/fetch-active-dRep branch February 25, 2025 07:26
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

MSzalowski added a commit that referenced this pull request Feb 26, 2025
…the-direct-voter-card-and-drep-details-page-adjustments

feat(#3072): remove own voting power from cards and drep details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants