Fix: proposal submission metadata issue, handle missing wallets file, and improve active dRep fetch retries#3091
Conversation
kneerose
changed the title
|
✅ All checks succeeded |
2 similar comments
|
✅ All checks succeeded |
|
✅ All checks succeeded |
| (element: IDRep) => element.givenName != null && !element.isScriptBased | ||
| (element: IDRep) => | ||
| element.givenName != null && | ||
| !element.isScriptBased && |
There was a problem hiding this comment.
Why do we ignore the scriptBased dreps here?
There was a problem hiding this comment.
Script-based dReps are ignored to fix the conflict between the API response's dRep view and the displayed card's dRepId.
If script-based dReps are not ignored, we need to update the dRepId view by changing 'drep' to 'drep_script', which may also affect other tests that depend on this helper function
There was a problem hiding this comment.
There is a issue by @Ryun1 and a PR by @MSzalowski for CIP-129
- 💡 Tweaks to DRep IDs - change default ID to CIP129 #2658
- feat: make CIP-129 identifiers default ones #2667
Was that reverted? Is there a reason we switched to CIP105
There was a problem hiding this comment.
It appears that the drepIds both cip105 and 129 are re-calculated in frontend using api's response
There was a problem hiding this comment.
Yes, before this update, CIP-105 acted as the default dRep, but now CIP-129 serves as the default dRepId on the frontend. However, the API still responds with CIP-105 dRepId
There was a problem hiding this comment.
Well if it's for random drep selection, we can ignore it.
|
@kneerose |
|
@kneerose |
|
@kneerose |
2 participants
List of changes
Checklist