Skip to content

Add automated tests for Outcomes pilar#3120

Merged
kneerose merged 18 commits into
developfrom
tests/outcomes
Mar 4, 2025
Merged

Add automated tests for Outcomes pilar#3120
kneerose merged 18 commits into
developfrom
tests/outcomes

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented Mar 4, 2025

List of changes

  • Add automated tests for Outcomes pilar
  • Make voting power feature flag generic for outcome and live voting
  • Make the extract expiry date functional for both outcome and live voting

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose
feat: add outcomes page and related tests for outcomes governance act…
4d18146 
…ions
@kneerose
feat: add outcome and outcomeMetadata types
a7e75d1
@kneerose
fix: update test IDs and filtering functionality
25e2be8
@kneerose
fix: search by id and title logic
f7ac54b
@kneerose
test: 9D. copy governance actionId
10a26a5
@kneerose
test: 9E. display only expired governance action
59608e9
@kneerose
test: 9F. add load more outcomes test
9243555
@kneerose
feat: extend outcomes type with more details
bb28bf6
@kneerose
refactor: enhance vote flag for both outcome and governance action
c7218b8
@kneerose
feat: add OutcomeDetailsPage class
cee1d29
@kneerose
feat: add filtering to outcomes page and implement view details funct…
5bf7da3 
…ionality
@kneerose
test: 9G. add verification for vote counts on outcome details page
a8785cf
@kneerose
fix: outcomes page visibility test for mobile access and improve filt…
b441c6d 
…ering logic
@kneerose
fix: add assertions for governance actions presence outcome search
996c61d
@kneerose kneerose requested a review from MSzalowski as a code owner March 4, 2025 05:10
@kneerose kneerose requested a review from mesudip March 4, 2025 05:10
@kneerose kneerose linked an issue Mar 4, 2025 that may be closed by this pull request
Add automated tests for Outcomes pilar #3102
Closed
@kneerose kneerose removed a link to an issue Mar 4, 2025
Add automated tests for Outcomes pilar #3102
Closed
@kneerose kneerose linked an issue Mar 4, 2025 that may be closed by this pull request
Add automated tests for Outcomes pilar #3102
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2025

✅ All checks succeeded

mesudip
mesudip suggested changes Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's good

Comment thread tests/govtool-frontend/playwright/lib/helpers/extractExpiryDateFromText.ts Outdated
Comment thread tests/govtool-frontend/playwright/tests/9-outcomes/outcomes.spec.ts Outdated
@kneerose kneerose requested a review from mesudip March 4, 2025 07:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2025

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2025

✅ All checks succeeded

@kneerose kneerose merged commit 4430949 into develop Mar 4, 2025
@kneerose kneerose deleted the tests/outcomes branch March 4, 2025 07:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2025

@kneerose
This PR is in the tag: develop-4430949075936afd78b15068ce39477d6685a45b , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2025

@kneerose
This PR is in the tag: develop-4430949075936afd78b15068ce39477d6685a45b , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2025

@kneerose
This PR is in the tag: develop-4430949075936afd78b15068ce39477d6685a45b , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MSzalowski MSzalowski Awaiting requested review from MSzalowski

1 more reviewer

@mesudip mesudip mesudip approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add automated tests for Outcomes pilar

2 participants

@kneerose @mesudip