Skip to content

fix(#3134): calculating withdrawals when there are no rewards#3136

Merged
MSzalowski merged 1 commit into
developfrom
fix/3134-incorrect-delegation-amount
Mar 5, 2025
Merged

fix(#3134): calculating withdrawals when there are no rewards#3136
MSzalowski merged 1 commit into
developfrom
fix/3134-incorrect-delegation-amount

Conversation

@MSzalowski
Copy link
Copy Markdown
Contributor

@MSzalowski MSzalowski commented Mar 5, 2025

List of changes

  • add conditional subtracting of withdrawals until records with rewards are populated in db-sync.
    Referring to the db-sync documentation rewards might not be populated instantly making the balance negative when withdrawals of rewards are existing

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski requested a review from Ryun1 as a code owner March 5, 2025 09:09
@MSzalowski MSzalowski linked an issue Mar 5, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2025

✅ All checks succeeded

@MSzalowski MSzalowski requested a review from placek March 5, 2025 09:35
@MSzalowski MSzalowski merged commit 68fa42b into develop Mar 5, 2025
@MSzalowski MSzalowski deleted the fix/3134-incorrect-delegation-amount branch March 5, 2025 10:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2025

@MSzalowski
This PR is in the tag: develop-68fa42bc4944d96270763b96534a963bcebef411 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2025

@MSzalowski
This PR is in the tag: develop-68fa42bc4944d96270763b96534a963bcebef411 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2025

@MSzalowski
This PR is in the tag: develop-68fa42bc4944d96270763b96534a963bcebef411 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Incorrect Delegation amount

2 participants