Skip to content

Add proposal metadata error behaviour test for both live voting and outcomes #3152

Merged
mesudip merged 3 commits into
developfrom
tests/invalid-metadata
Mar 11, 2025
Merged

Add proposal metadata error behaviour test for both live voting and outcomes #3152
mesudip merged 3 commits into
developfrom
tests/invalid-metadata

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented Mar 6, 2025

List of changes

  • Add proposal metadata error behaviour test for both live voting and outcomes

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip March 6, 2025 06:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2025

✅ All checks succeeded

Copy link
Copy Markdown
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mesudip
Copy link
Copy Markdown
Contributor

mesudip commented Mar 6, 2025

Let's also add a test case for

  • metadata-url and hash match, but the content in the data is drep registration instead of gov-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 7, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 7, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 7, 2025

✅ All checks succeeded

@kneerose kneerose requested a review from mesudip March 10, 2025 11:02
Copy link
Copy Markdown
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mesudip mesudip merged commit 376c95e into develop Mar 11, 2025
@mesudip mesudip deleted the tests/invalid-metadata branch March 11, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants