Skip to content

hotfix: fix ada handle and payment address validation order #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MSzalowski merged 1 commit into from
Mar 11, 2025
Merged

hotfix: fix ada handle and payment address validation order #3178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@ changes.

### Fixed

- hotfix for ada handle and payment address validation order [Issue 3155](https://github.com/IntersectMBO/govtool/issues/3155)

### Changed

### Removed

## [v2.0.15](https://github.com/IntersectMBO/govtool/releases/tag/v2.0.15) 2025-03-11


### Added

- Add support for ada handle in drep payment address [Issue 3155](https://github.com/IntersectMBO/govtool/issues/3155)
Expand Down
10 changes: 6 additions & 4 deletions govtool/frontend/src/utils/isValidFormat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,18 @@ export async function isReceivingAddress(address?: string) {
return true;
}

const receivingAddress = Address.from_bech32(address);
if (receivingAddress) {
return true;
}
// Validation for ada handles needs to go first as
// handles might be shorter then bech32 addresses
const isValidAdaHandle = await adaHandleService.isValidAdaHandle(address);

if (isValidAdaHandle) {
return true;
}

const receivingAddress = Address.from_bech32(address);
if (receivingAddress) {
return true;
}
return i18n.t("forms.errors.mustBeReceivingAddress");
} catch (e) {
return i18n.t("forms.errors.mustBeReceivingAddress");
Expand Down