Skip to content

Fix: report 352 test issue#3186

Merged
kneerose merged 6 commits into
developfrom
fix/report-352-issue
Mar 12, 2025
Merged

Fix: report 352 test issue#3186
kneerose merged 6 commits into
developfrom
fix/report-352-issue

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented Mar 12, 2025

List of changes

  • Update dRep directory delegated ada format
  • Skip bootstraping test
  • Fixed dRep form payment address validation issue due to block by wallet connect popup
  • Increased some assertion timeout

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from MSzalowski as a code owner March 12, 2025 09:25
@kneerose kneerose requested a review from mesudip March 12, 2025 09:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

✅ All checks succeeded

mesudip
mesudip approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

Comment thread ...ovtool-frontend/playwright/tests/5-proposal-functionality/proposalFunctionality.dRep.spec.ts Outdated
test("5L. Should restrict dRep votes to Info Governance actions During Bootstrapping Phase", async ({
browser,
}) => {
await allure.description(
Copy link
Copy Markdown
Contributor

@mesudip mesudip Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these tests. I don't see any future usefulness of these tests

Copy link
Copy Markdown
Contributor Author

@kneerose kneerose Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread tests/govtool-frontend/playwright/tests/6-miscellaneous/miscellaneous.spec.ts Outdated
page,
context,
}) => {
await allure.description(
Copy link
Copy Markdown
Contributor

@mesudip mesudip Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the test.

Copy link
Copy Markdown
Contributor Author

@kneerose kneerose Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kneerose kneerose merged commit cbad111 into develop Mar 12, 2025
@kneerose kneerose deleted the fix/report-352-issue branch March 12, 2025 11:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

✅ All checks succeeded

@kneerose kneerose mentioned this pull request Mar 12, 2025
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-metadata-validation service

6 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-frontend service

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-frontend service

4 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-backend service

6 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025

@kneerose
This PR is in the tag: develop-cbad1110fd35b548a9ff870c3c6a04312a8e2a49-13 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MSzalowski MSzalowski Awaiting requested review from MSzalowski

1 more reviewer

@mesudip mesudip mesudip approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kneerose @mesudip