Skip to content

fix(#3190): add pre filtering of active proposals to sql#3195

Merged
MSzalowski merged 1 commit into
developfrom
fix/3190-rewrite-votes-calculation-for-proposals
Mar 14, 2025
Merged

fix(#3190): add pre filtering of active proposals to sql#3195
MSzalowski merged 1 commit into
developfrom
fix/3190-rewrite-votes-calculation-for-proposals

Conversation

@MSzalowski
Copy link
Copy Markdown
Contributor

@MSzalowski MSzalowski commented Mar 14, 2025

List of changes

  • add pre filtering of active proposals to sql which allows to prefilter also votes and the other joined tables

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski requested a review from Ryun1 as a code owner March 14, 2025 08:41
@MSzalowski MSzalowski linked an issue Mar 14, 2025 that may be closed by this pull request
💡 Rewrite votes calculation for proposals #3190
Closed
@MSzalowski MSzalowski requested a review from placek March 14, 2025 08:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/3190-rewrite-votes-calculation-for-proposals branch from c8acd75 to b4199fa Compare March 14, 2025 10:01
@MSzalowski MSzalowski merged commit 5716c36 into develop Mar 14, 2025
@MSzalowski MSzalowski deleted the fix/3190-rewrite-votes-calculation-for-proposals branch March 14, 2025 10:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-metadata-validation service

6 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-frontend service

6 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-backend service

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-backend service

4 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

@MSzalowski
This PR is in the tag: develop-5716c36f7bb23a27b2aaf49df85e1180fb51ae0d-14 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

1 more reviewer

@placek placek placek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

💡 Rewrite votes calculation for proposals

2 participants

@MSzalowski @placek