Skip to content

Fix: broken/failing test due to update on metrics api#3223

Merged
kneerose merged 3 commits into
developfrom
fix/test-metrics-api-issue
Mar 18, 2025
Merged

Fix: broken/failing test due to update on metrics api#3223
kneerose merged 3 commits into
developfrom
fix/test-metrics-api-issue

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

List of changes

  • Change metrics intercept to info for the network name.
  • Change metrics intercept to total-stake for alwaysAbstainVotingPower in live voting.
  • Fix the parsing issue on alwaysAbstainVotingPower for the outcome.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from MSzalowski as a code owner March 18, 2025 06:27
@kneerose kneerose requested a review from mesudip March 18, 2025 06:27
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

Copy link
Copy Markdown
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose kneerose merged commit c80693b into develop Mar 18, 2025
@kneerose kneerose deleted the fix/test-metrics-api-issue branch March 18, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants