-
Notifications
You must be signed in to change notification settings - Fork 23
Tests: script based dRep conversion #3224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a6ca482
chore: change convertDRepToCIP129 to convertDRep and use for both con…
kneerose 3817a4a
test: add mock data and tests for converting script DRep to CIP-129/C…
kneerose 6ac3128
chore: check conversion for both script/ non-script drep
kneerose c62cf0d
fix: vote assertion check issue on revote with updated context
kneerose File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
tests/govtool-frontend/playwright/lib/_mock/scriptDRep.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
| "page": 0, | ||
| "pageSize": 10, | ||
| "total": 1, | ||
| "elements": [ | ||
| { | ||
| "isScriptBased": true, | ||
| "drepId": "429b12461640cefd3a4a192f7c531d8f6c6d33610b727f481eb22d39", | ||
| "view": "drep1g2d3y3skgr806wj2ryhhc5ca3akx6vmppde87jq7kgknjmv589e", | ||
| "url": null, | ||
| "metadataHash": null, | ||
| "deposit": 500000000, | ||
| "votingPower": 83414740266257, | ||
| "status": "Active", | ||
| "type": "SoleVoter", | ||
| "latestTxHash": "8de2a5f9074679de947549ea36c3980496503ffc40f0cbce5ce1ee3df66306e9", | ||
| "latestRegistrationDate": "2024-11-20T01:59:20Z", | ||
| "metadataError": null, | ||
| "paymentAddress": null, | ||
| "givenName": null, | ||
| "objectives": null, | ||
| "motivations": null, | ||
| "qualifications": null, | ||
| "imageUrl": null, | ||
| "imageHash": null | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have similar test for
keyDrep? If not let's add it too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can review this update -https://github.com/IntersectMBO/govtool/pull/3224/files#:~:text=.isScriptBased)-,const%20cip129DRepListApi%20%3D%20dRepList.map(,)%3B,-for%20(let. This is the only test where the conversion of a dRep takes place, whether it's script-based or a normal dRep.