Skip to content

fix(#3242): bug incorrect redirect after voting on governance action#3248

Merged
MSzalowski merged 2 commits into
developfrom
fix/3242-bug-incorrect-redirect-after-voting-on-governance-action
Mar 20, 2025
Merged

fix(#3242): bug incorrect redirect after voting on governance action#3248
MSzalowski merged 2 commits into
developfrom
fix/3242-bug-incorrect-redirect-after-voting-on-governance-action

Conversation

@MSzalowski
Copy link
Copy Markdown
Contributor

@MSzalowski MSzalowski commented Mar 19, 2025

List of changes

  • Fix fetching the drep votes
  • Fix filtering the governance action to vote, and voted on actions
  • Fix redirection to empty governance action list

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski requested a review from Ryun1 as a code owner March 19, 2025 14:12
@MSzalowski MSzalowski linked an issue Mar 19, 2025 that may be closed by this pull request
🐛 Bug: Incorrect Redirect After Voting on Governance Action #3242
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2025

✅ All checks succeeded

@MSzalowski MSzalowski requested review from bosko-m and placek March 20, 2025 09:28
@MSzalowski MSzalowski merged commit cb64984 into develop Mar 20, 2025
@MSzalowski MSzalowski deleted the fix/3242-bug-incorrect-redirect-after-voting-on-governance-action branch March 20, 2025 11:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-metadata-validation service

6 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-backend service

6 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-frontend service

3 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-frontend service

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@MSzalowski
This PR is in the tag: develop-cb64984671491dac09d9c215fead72591d93f788-26 , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@bosko-m bosko-m Awaiting requested review from bosko-m

1 more reviewer

@placek placek placek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Incorrect Redirect After Voting on Governance Action

2 participants

@MSzalowski @placek