Skip to content

Fix: report 377 issue #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spannercode merged 4 commits into from
Apr 10, 2025
Merged

Fix: report 377 issue #3387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b579be9
fix: update multipleDRepRegistration to use proposalFaucetWallet
kneerose Apr 4, 2025
dd5072b
fix: reduce comment length in budget proposal tests
kneerose Apr 4, 2025
521d2fd
chore: add proper messge for comment length invalid issue
kneerose Apr 4, 2025
ca8d2e5
fix: comment count issue
kneerose Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/govtool-frontend/playwright/lib/services/kuberService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,10 @@ const kuberService = {
},

multipleDRepRegistration: (metadataAndWallets: WalletAndAnchorType[]) => {
const kuber = new Kuber(faucetWallet.address, faucetWallet.payment.private);
const kuber = new Kuber(
proposalFaucetWallet.address,
proposalFaucetWallet.payment.private
);
const req = {
certificates: metadataAndWallets.map((metadataAndWallet) =>
Kuber.generateCert(
Expand Down
4 changes: 2 additions & 2 deletions tests/govtool-frontend/playwright/tests/11-proposal-budget/proposalBudget.loggedin.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ test.describe("Budget proposal logged in state", () => {
});

test("11I. Should comments on any proposal", async ({}) => {
const comment = faker.lorem.paragraph(2);
const comment = faker.lorem.paragraph(1);
await budgetDiscussionDetailsPage.addComment(comment);
await expect(
budgetDiscussionDetailsPage.currentPage
Expand All @@ -59,7 +59,7 @@ test.describe("Budget proposal logged in state", () => {
});

test("11J. Should reply to any comments", async ({}) => {
const randComment = faker.lorem.paragraph(2);
const randComment = faker.lorem.paragraph(1);
const randReply = faker.lorem.words(5);

await budgetDiscussionDetailsPage.addComment(randComment);
Expand Down
22 changes: 16 additions & 6 deletions tests/govtool-frontend/playwright/tests/11-proposal-budget/proposalBudget.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ test("11E. Should view comments with count indications on a budget proposal", as
page,
}) => {
let responsePromise = page.waitForResponse((response) =>
response.url().includes(`/api/comments`)
response.url().includes(`/api/bds/`)
);

const budgetDiscussionPage = new BudgetDiscussionPage(page);
Expand All @@ -197,13 +197,23 @@ test("11E. Should view comments with count indications on a budget proposal", as
await budgetDiscussionPage.viewFirstProposal();
const response = await responsePromise;

const comments: CommentResponse[] = (await response.json()).data;
const proposalResponse = await response.json();

await responsePromise;
const actualTotalComments =
await budgetDiscussionDetailsPage.totalComments.textContent();
const expectedTotalComments =
proposalResponse.data.attributes.prop_comments_number.toString();
const isEqual = actualTotalComments === expectedTotalComments;

await expect(budgetDiscussionDetailsPage.totalComments).toHaveText(
comments.length.toString()
);
const currentPageUrl = budgetDiscussionDetailsPage.currentPage.url();

const proposalId = extractProposalIdFromUrl(currentPageUrl);

await expect(
budgetDiscussionDetailsPage.totalComments,
!isEqual &&
`Total comments do not match in ${environments.frontendUrl}/budget_discussion/${proposalId}`
).toHaveText(expectedTotalComments);
});

test.describe("Restricted access to interact budget proposal", () => {
Expand Down