Skip to content

Fix network metrics type and add test for network total stakes and info #3515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kneerose merged 2 commits into from
Apr 22, 2025
Merged

Fix network metrics type and add test for network total stakes and info #3515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c4e87a
fix: network metrics response
kneerose Apr 22, 2025
1bdc527
test: add network total stake and network info response type validati…
kneerose Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/govtool-backend/lib/govtool_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,12 @@ def validate_metadata(self, metadata) -> Response:

def network_metrics(self) -> Response:
return self.__get("/network/metrics")

def network_total_stake(self) -> Response:
return self.__get("/network/total-stake")

def network_info(self) -> Response:
return self.__get("/network/info")

def get_transaction_status(self, tx_id) -> Response:
return self.__get("/transaction/status", tx_id)
Expand Down
21 changes: 18 additions & 3 deletions tests/govtool-backend/models/TestData.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,28 @@ class TxStatus(TypedDict):


class NetworkMetrics(TypedDict):
currentTime: str
currentEpoch: int
currentBlock: int
uniqueDelegators: int
totalDelegations: int
totalGovernanceActions: int
totalDRepVotes: int
totalRegisteredDReps: int
totalDRepDistr: int
totalActiveDReps: int
totalInactiveDReps: int
totalActiveCIP119CompliantDReps: int
totalRegisteredDirectVoters: int
noOfCommitteeMembers: int
quorumNumerator: int
quorumDenominator: int

class NetworkTotalStake(TypedDict):
totalStakeControlledByDReps: int
totalStakeControlledBySPOs: int
alwaysAbstainVotingPower: int
alwaysNoConfidenceVotingPower: int

class NetworkInfo(TypedDict):
currentTime: str
epochNo: int
blockNo: int
networkName: str
18 changes: 17 additions & 1 deletion tests/govtool-backend/test_cases/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import allure

from lib.assertions import assert_data_type
from models.TestData import EpochParam, NetworkMetrics, TxStatus
from models.TestData import EpochParam, NetworkInfo, NetworkMetrics, NetworkTotalStake, TxStatus


def validate_epoch_param(epoch_param):
Expand All @@ -10,6 +10,12 @@ def validate_epoch_param(epoch_param):

def validate_network_metrics(network_metrics):
assert_data_type(NetworkMetrics, network_metrics)

def validate_network_total_stake(network_total_stake):
assert_data_type(NetworkTotalStake, network_total_stake)

def validate_network_info(network_info):
assert_data_type(NetworkInfo, network_info)


@allure.story("Misc")
Expand All @@ -22,6 +28,16 @@ def test_get_epoch_param(govtool_api):
def test_get_network_metrics(govtool_api):
network_metrics = govtool_api.network_metrics().json()
validate_network_metrics(network_metrics)

@allure.story("Misc")
def test_get_network_total_stake(govtool_api):
network_total_stake = govtool_api.network_total_stake().json()
validate_network_total_stake(network_total_stake)

@allure.story("Misc")
def test_get_network_info(govtool_api):
network_info = govtool_api.network_info().json()
validate_network_info(network_info)


@allure.story("Misc")
Expand Down