Skip to content

Refactor: Auth setup and Test Structure Improvements#3523

Merged
kneerose merged 11 commits into
developfrom
refactor/auth-setup
Apr 29, 2025
Merged

Refactor: Auth setup and Test Structure Improvements#3523
kneerose merged 11 commits into
developfrom
refactor/auth-setup

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented Apr 24, 2025

List of changes

  • Refactored authentication logic into modular setup files:
    • dRep.auth.setup.ts for dRep authentication
    • proposal-discussion.auth.setup.ts for proposal discussion
    • budget-discussion.auth.setup.ts for budget discussion
    • adaholder.auth.setup.ts and user.auth.setup.ts for Adaholder and User authentication respectively
  • Updated Playwright project structure to load only relevant auth setup files based on test context
  • Replaced hardcoded authentication values with a centralized auth constants file
  • Moved dRep registration tests from misc to a dRepRegistration directory
  • Added DEV_URL support for manual workflow dispatch
  • Remove unnecessary skipIfHardFork function and its uses

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

8 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose kneerose requested a review from placek as a code owner April 25, 2025 08:10
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose kneerose changed the title Refactor: auth setup Refactor: Auth setup and Test Structure Improvements Apr 28, 2025
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose kneerose merged commit 05df90a into develop Apr 29, 2025
3 checks passed
@kneerose kneerose deleted the refactor/auth-setup branch April 29, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants