Skip to content

hotfix: randomly missing GAs metadata #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MSzalowski merged 8 commits into from
May 8, 2025
Merged

hotfix: randomly missing GAs metadata #3528

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e83f11d
Merge pull request #3506 from IntersectMBO/test
MSzalowski Apr 18, 2025
67838a9
Merge pull request #3507 from IntersectMBO/staging
MSzalowski Apr 18, 2025
9303f25
hotfix: randomly missing GAs metadata
MSzalowski Apr 24, 2025
566b8f2
Merge pull request #3525 from IntersectMBO/hotfix/randomly-missing-va…
MSzalowski Apr 24, 2025
59ffaf8
Merge pull request #3527 from IntersectMBO/main
MSzalowski Apr 24, 2025
b5e6658
Merge pull request #3547 from IntersectMBO/test
MSzalowski Apr 29, 2025
8f01b4e
Merge pull request #3578 from IntersectMBO/test
bosko-m May 6, 2025
97b4925
Merge pull request #3599 from IntersectMBO/test
MSzalowski May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions govtool/frontend/src/components/organisms/DashboardGovernanceActionDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ export const DashboardGovernanceActionDetails = () => {
const { isMobile } = useScreenDimension();
const { t } = useTranslation();
const { proposalId: txHash } = useParams();

const [isValidating, setIsValidating] = useState(true);
const [metadataStatus, setMetadataStatus] = useState<
MetadataValidationStatus | undefined
>();
const [isMetadataValid, setIsMetadataValid] = useState<boolean | undefined>();
const fullProposalId = txHash && getFullGovActionId(txHash, +index);
const shortenedGovActionId =
txHash && getShortenedGovActionId(txHash, +index);
Expand All @@ -56,16 +60,12 @@ export const DashboardGovernanceActionDetails = () => {
);

useEffect(() => {
if (data?.proposal) {
if (data?.proposal && typeof isMetadataValid !== "boolean") {
setExtendedProposal(data.proposal);
}
}, [data?.proposal]);
}, [data?.proposal, isMetadataValid]);
const vote = (data ?? state)?.vote;

const [isValidating, setIsValidating] = useState(true);
const [metadataStatus, setMetadataStatus] = useState<
MetadataValidationStatus | undefined
>();
const { validateMetadata } = useValidateMutation();

useEffect(() => {
Expand All @@ -74,7 +74,7 @@ export const DashboardGovernanceActionDetails = () => {
const validate = async () => {
setIsValidating(true);

const { status, metadata } = await validateMetadata({
const { status, metadata, valid } = await validateMetadata({
standard: MetadataStandard.CIP108,
url: extendedProposal?.url,
hash: extendedProposal?.metadataHash ?? "",
Expand All @@ -92,9 +92,10 @@ export const DashboardGovernanceActionDetails = () => {

setMetadataStatus(status);
setIsValidating(false);
setIsMetadataValid(valid);
};
validate();
}, [extendedProposal?.url]);
}, [extendedProposal?.url, extendedProposal?.metadataHash]);

useEffect(() => {
const isProposalNotFound =
Expand Down