Skip to content

Refactor: project structure#3564

Merged
kneerose merged 25 commits into
developfrom
refactor/project-structure
May 5, 2025
Merged

Refactor: project structure#3564
kneerose merged 25 commits into
developfrom
refactor/project-structure

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented May 5, 2025

List of changes

  • Remove the unnecessary faucet/proposal wallet.
  • Use faucet credentials and address from the environment variables to load all test wallets.
  • Check the available balance of the faucet address and skip dependent setup and tests if the balance is insufficient.
  • Add the project structure and architecture documentation.
  • Update the README and developer guide.
  • Add cleanup artifacts teardown to remove all JSON files generated during test execution.
  • Refactor the dRep registration validation test.
  • Use the default test execution deployment URL https://p80-z6b8d2f7a-ze34e4cb2-gtw.z937eb260.rustrocks.fr/ and include it in the manual trigger.
  • Fix outcome flaky test due to interscept logic

Added ENV

  • FAUCET_PAYMENT_PRIVATE: ${{secrets.FAUCET_PAYMENT_PRIVATE}}
  • FAUCET_STAKE_PKH: ${{secrets.FAUCET_STAKE_PKH}}

Removed ENV from integration test

  • FAUCET_API_KEY_PREPROD
  • FAUCET_API_KEY_SANCHONET
  • FAUCET_API_KEY_PREVIEW
  • API URL
  • PROPOSAL_FAUCET_PAYMENT_PRIVATE
  • PROPOSAL_FAUCET_STAKE_PRIVATE
  • PROPOSAL_FAUCET_DREP_PRIVATE

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

kneerose added 21 commits May 5, 2025 10:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

3 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

@kneerose kneerose requested a review from mesudip May 5, 2025 10:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

Comment thread .github/workflows/test_integration_playwright.yml Outdated
@kneerose kneerose merged commit 3a0efd6 into develop May 5, 2025
3 checks passed
@kneerose kneerose deleted the refactor/project-structure branch May 5, 2025 10:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

✅ All checks succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants