Skip to content

fix(#3591): remove canonicalization from the governance action metadata#3595

Merged
MSzalowski merged 1 commit into
developfrom
workaround/3591-bug-govtool-metadata-hash-validation-ignores-extra-byte-in-the-manually-created-files
May 8, 2025
Merged

fix(#3591): remove canonicalization from the governance action metadata#3595
MSzalowski merged 1 commit into
developfrom
workaround/3591-bug-govtool-metadata-hash-validation-ignores-extra-byte-in-the-manually-created-files

Conversation

@MSzalowski
Copy link
Copy Markdown
Contributor

List of changes

  • Remvoe optional support for the original CIP-108 standard where the canonicalization were required

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2025

✅ All checks succeeded

@MSzalowski MSzalowski requested a review from placek May 8, 2025 10:32
@MSzalowski MSzalowski merged commit b5b8072 into develop May 8, 2025
3 checks passed
@MSzalowski MSzalowski deleted the workaround/3591-bug-govtool-metadata-hash-validation-ignores-extra-byte-in-the-manually-created-files branch May 8, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: GovTool Metadata Hash Validation Ignores extra byte in the Manually Created Files

3 participants