Skip to content

fix: wrong metadata status background on voted on card #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MSzalowski merged 1 commit into from
May 9, 2025
Merged

fix: wrong metadata status background on voted on card #3604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ changes.

### Fixed

- Fix invalid metadata status background on voted on card

### Changed

### Removed
Expand Down
8 changes: 6 additions & 2 deletions govtool/frontend/src/components/molecules/GovernanceVotedOnCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ export const GovernanceVotedOnCard = ({
bech32Prefix: "gov_action",
});

// When no status provided into the metadataStatus prop,
// we consider it as a valid
const isMetadataValid = metadataStatus === undefined;

return (
<Box
sx={{
Expand All @@ -67,13 +71,13 @@ export const GovernanceVotedOnCard = ({
justifyContent: "space-between",
boxShadow: "0px 4px 15px 0px #DDE3F5",
borderRadius: "20px",
backgroundColor: !metadataStatus
backgroundColor: !isMetadataValid
? "rgba(251, 235, 235, 0.50)"
: "rgba(255, 255, 255, 0.3)",
// TODO: To decide if voted on cards can be actually in progress
border: inProgress
? "1px solid #FFCBAD"
: !metadataStatus
: !isMetadataValid
? "1px solid #F6D5D5"
: "1px solid #C0E4BA",
}}
Expand Down