Skip to content

Fix: insufficient proposal balance issue#3606

Merged
kneerose merged 7 commits into
developfrom
fix/insufficient-proposal-balance-issue
May 12, 2025
Merged

Fix: insufficient proposal balance issue#3606
kneerose merged 7 commits into
developfrom
fix/insufficient-proposal-balance-issue

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented May 9, 2025

List of changes

  • Add an extra temporary wallet for proposal submission to support balance-dependent test cases 7J_1, 7J_2, 7K, and 8U.
  • Implement a test prompt to display an insufficient balance modal when the wallet balance is inadequate after clicking the "Submit as a Governance Action" button.
  • Configure the authentication setup for the proposal submission balance-dependent wallet.
  • Update the project structure and README to reflect the revised flow for proposal discussion.
  • Fix the reply testId issue in the budget proposal.
  • Log wallet details during proposal submission for governance action tests.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested review from MSzalowski and Ryun1 as code owners May 9, 2025 09:49
@kneerose kneerose requested a review from mesudip May 9, 2025 09:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2025

✅ All checks succeeded

@kneerose kneerose merged commit 6c145b7 into develop May 12, 2025
5 of 7 checks passed
@kneerose kneerose deleted the fix/insufficient-proposal-balance-issue branch May 12, 2025 04:56
@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-6c145b74acba99e62b702adfb7798f52f090154f , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-6c145b74acba99e62b702adfb7798f52f090154f , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@kneerose
This PR is in the tag: develop-6c145b74acba99e62b702adfb7798f52f090154f , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants