Skip to content

fix(#3560): allow empty image in register drep form#3621

Merged
MSzalowski merged 4 commits into
developfrom
fix/3560-allow-empty-image-in-drep-form
May 14, 2025
Merged

fix(#3560): allow empty image in register drep form#3621
MSzalowski merged 4 commits into
developfrom
fix/3560-allow-empty-image-in-drep-form

Conversation

@Ciabas
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas commented May 13, 2025

List of changes

  • Fix an issue where the submit button remained disabled after removing an invalid value from the IMAGE input field on DRrep form.
  • Fix precise types in UncontrolledImageInput component to improve type safety.
  • Fix error styles in UncontrolledImageInput - blank message field falsely suggested that the input had no errors, even though it had them

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Ciabas Ciabas requested review from MSzalowski and Ryun1 as code owners May 13, 2025 08:24
@Ciabas Ciabas changed the title Fix/3560 allow empty image in drep form fix(#3560): allow empty image in register drep form May 13, 2025
@Ciabas Ciabas self-assigned this May 13, 2025
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

Ciabas added 2 commits May 13, 2025 10:27
…fieldState.error, ensuring users see input errors even with empty messages
@Ciabas Ciabas force-pushed the fix/3560-allow-empty-image-in-drep-form branch from 89aacd9 to 1d1d231 Compare May 13, 2025 08:27
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

3 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

Signed-off-by: Artur W. <ciabas12@gmail.com>
@MSzalowski MSzalowski merged commit b1b55d0 into develop May 14, 2025
8 checks passed
@MSzalowski MSzalowski deleted the fix/3560-allow-empty-image-in-drep-form branch May 14, 2025 12:06
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-b1b55d007bdc61bf797860fbf0a8f5954fa942d6 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-b1b55d007bdc61bf797860fbf0a8f5954fa942d6 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-b1b55d007bdc61bf797860fbf0a8f5954fa942d6 , for govtool-frontend service

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants