Skip to content

Fix: report 410 issue#3645

Merged
kneerose merged 6 commits into
developfrom
fix/report-410-issue
May 22, 2025
Merged

Fix: report 410 issue#3645
kneerose merged 6 commits into
developfrom
fix/report-410-issue

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

List of changes

  • Add helper function to add dRep given name on the static wallet
  • Update dRep comment visibility assert
  • Fix costing rejection test by filling in the cost breakdown last, to focus after filling out the currency inputs
  • Trim proposal title to fix flaky test on proposal discussion

Checklist

  • related report
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from MSzalowski as a code owner May 19, 2025 06:38
@kneerose kneerose requested a review from mesudip May 19, 2025 06:38
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose kneerose merged commit e528f5f into develop May 22, 2025
3 checks passed
@kneerose kneerose deleted the fix/report-410-issue branch May 22, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants