feat: add support for Parameter Change and Hard Fork Initiation gov actions creation#3660
Merged
MSzalowski merged 1 commit intoMay 22, 2025
Conversation
Contributor
|
✅ All checks succeeded |
2 similar comments
Contributor
|
✅ All checks succeeded |
Contributor
|
✅ All checks succeeded |
Ciabas
approved these changes
May 22, 2025
Contributor
Ciabas
left a comment
Ciabas
left a comment
There was a problem hiding this comment.
I don't see anything fishy here. 👍
There is no big risk, since it is behind the flag and I won't be used on production anyway.
Sorry, but I only took a brief glance on the haskel code.
| constitutionHash: FieldSchema; | ||
| scriptHash: FieldSchema; | ||
| }>; | ||
| export type ProtocolParameterActionFieldSchema = Partial<{ |
Contributor
There was a problem hiding this comment.
[question]
I believe that Partial is not changing the deeply nested structure. So the end result of it is just:
{
prevGovernanceActionHash?: FieldSchema;
prevGovernanceActionIndex?: FieldSchema;
protocolParameters?: FieldSchema;
}| useEffect(() => { | ||
| if (govActionType === GovernanceActionType.ParameterChange) { | ||
| setValue("protocolParameters", JSON.stringify(protocolParams)); | ||
| } |
Contributor
There was a problem hiding this comment.
Do we want to clear those values just in case in for all the other types?
MSzalowski
force-pushed
the
feat/add-support-for-hard-fork-and-protocol-parameter-gov-actions-creation
branch
from
78fe42a to
a39bd39
Compare
Contributor
|
✅ All checks succeeded |
MSzalowski
deleted the
feat/add-support-for-hard-fork-and-protocol-parameter-gov-actions-creation
branch
Contributor
|
✅ All checks succeeded |
1 similar comment
Contributor
|
✅ All checks succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist