Skip to content

feat(#3672): add /account service for the usage of Proposal Discussion Forum pillar#3687

Merged
Ciabas merged 2 commits into
developfrom
3672-add-account-service-for-the-usage-of-proposal-discussion-forum-pillar
May 29, 2025
Merged

feat(#3672): add /account service for the usage of Proposal Discussion Forum pillar#3687
Ciabas merged 2 commits into
developfrom
3672-add-account-service-for-the-usage-of-proposal-discussion-forum-pillar

Conversation

@Ciabas
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas commented May 27, 2025

List of changes

  • Add /account service for the usage of Proposal Discussion Forum pillar

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Ciabas Ciabas requested review from MSzalowski and Ryun1 as code owners May 27, 2025 09:24
@Ciabas Ciabas marked this pull request as draft May 27, 2025 09:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2025

❌ Docker Image Scan (Dockle) failed

No output

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2025

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3672-add-account-service-for-the-usage-of-proposal-discussion-forum-pillar branch from 9fcf412 to 3dc02c0 Compare May 27, 2025 12:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3672-add-account-service-for-the-usage-of-proposal-discussion-forum-pillar branch from 3dc02c0 to b5f778f Compare May 27, 2025 13:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2025

✅ All checks succeeded

@Ciabas Ciabas marked this pull request as ready for review May 28, 2025 07:36
@Ciabas Ciabas marked this pull request as draft May 28, 2025 07:36
@Ciabas Ciabas marked this pull request as ready for review May 29, 2025 07:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2025

✅ All checks succeeded

@Ciabas Ciabas requested a review from MSzalowski May 29, 2025 08:23
MSzalowski
MSzalowski approved these changes May 29, 2025
View reviewed changes
Comment thread govtool/backend/src/VVA/API/Types.hs
"{\"stakeKey\": \"stake1u9\","
<> " \"id\": \"1\","
<> "\"view\": \"stake_test1uzapf83wydusjln97rqr7fen6vgrz5087yqdxm0akqdqkgstjz8g4\","
<> "\"view\": \"stake_test1uzapf83wydusjln97rqr7fen6vgrz5087yqdxm0akqdqkgstj2345\","
Copy link
Copy Markdown
Contributor

@MSzalowski MSzalowski May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that change needed? 🤔

Copy link
Copy Markdown
Contributor Author

@Ciabas Ciabas May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a real view there, so I modified it slightly to not use real data.

@Ciabas Ciabas merged commit 170b196 into develop May 29, 2025
5 checks passed
@Ciabas Ciabas deleted the 3672-add-account-service-for-the-usage-of-proposal-discussion-forum-pillar branch May 29, 2025 09:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2025

@Ciabas
This PR is in the tag: develop-170b196d160681afa22a96806dbb4173fe4a7a78 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2025

@Ciabas
This PR is in the tag: develop-170b196d160681afa22a96806dbb4173fe4a7a78 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2025

@Ciabas
This PR is in the tag: develop-170b196d160681afa22a96806dbb4173fe4a7a78 , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

1 more reviewer

@MSzalowski MSzalowski MSzalowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ciabas @MSzalowski