Skip to content

fix(#3681): preserve maintenance banner expanded state#3688

Merged
MSzalowski merged 2 commits into
developfrom
fix/3681-bug-red-banner-collapse-state-not-preserved-when-wallet-is-not-connected
May 28, 2025
Merged

fix(#3681): preserve maintenance banner expanded state#3688
MSzalowski merged 2 commits into
developfrom
fix/3681-bug-red-banner-collapse-state-not-preserved-when-wallet-is-not-connected

Conversation

@MSzalowski
Copy link
Copy Markdown
Contributor

@MSzalowski MSzalowski commented May 27, 2025

List of changes

  • preserve maintenance banner expanded state

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski requested a review from Ryun1 as a code owner May 27, 2025 10:35
@MSzalowski MSzalowski requested a review from Ciabas May 27, 2025 10:35
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/3681-bug-red-banner-collapse-state-not-preserved-when-wallet-is-not-connected branch from 8f38153 to 973ae3c Compare May 27, 2025 12:36
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

5 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

Copy link
Copy Markdown
Contributor

@Ciabas Ciabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks and works great, but it still unfolds when you refresh the page. Do we want to fix this now or deal with it later?

@MSzalowski MSzalowski force-pushed the fix/3681-bug-red-banner-collapse-state-not-preserved-when-wallet-is-not-connected branch from 7f2e477 to 2238a84 Compare May 28, 2025 11:44
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@MSzalowski
Copy link
Copy Markdown
Contributor Author

It looks and works great, but it still unfolds when you refresh the page. Do we want to fix this now or deal with it later?

I'll deal with that later

@MSzalowski MSzalowski requested a review from Ciabas May 28, 2025 12:06
@MSzalowski MSzalowski merged commit e1a8db7 into develop May 28, 2025
8 checks passed
@MSzalowski MSzalowski deleted the fix/3681-bug-red-banner-collapse-state-not-preserved-when-wallet-is-not-connected branch May 28, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Red Banner Collapse State Not Preserved When Wallet Is Not Connected

2 participants