Skip to content

Fix: wrap governance action expiry test with function waited assertion #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kneerose merged 1 commit into from
Jun 4, 2025
Merged

Fix: wrap governance action expiry test with function waited assertion #3722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions tests/govtool-frontend/playwright/tests/4-proposal-visibility/proposalVisibility.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,15 +199,19 @@ test("4H. Should verify none of the displayed governance actions have expired",
const govActionsPage = new GovernanceActionsPage(page);
await govActionsPage.goto();

const proposalCards = await govActionsPage.getAllProposals();

for (const proposalCard of proposalCards) {
const expiryDateEl = proposalCard.getByTestId("expiry-date");
const expiryDateTxt = await expiryDateEl.innerText();
const expiryDate = extractExpiryDateFromText(expiryDateTxt);
const today = new Date();
expect(today <= expiryDate).toBeTruthy();
}
await functionWaitedAssert(
async () => {
const proposalCards = await govActionsPage.getAllProposals();
for (const proposalCard of proposalCards) {
const expiryDateEl = proposalCard.getByTestId("expiry-date");
const expiryDateTxt = await expiryDateEl.innerText();
const expiryDate = extractExpiryDateFromText(expiryDateTxt);
const today = new Date();
expect(today <= expiryDate).toBeTruthy();
}
},
{ name: "verify none expired governance actions" }
);
});

test("4K. Should display correct vote counts on governance details page for disconnect state", async ({
Expand Down