Skip to content

fix(#3728): update red banner copy and behavior#3729

Merged
bosko-m merged 2 commits into
developfrom
3728-update-red-banner-copy-and-behavior-on-govtool
Jun 4, 2025
Merged

fix(#3728): update red banner copy and behavior#3729
bosko-m merged 2 commits into
developfrom
3728-update-red-banner-copy-and-behavior-on-govtool

Conversation

@Ciabas
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas commented Jun 4, 2025

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

The videos were made with 0.7s transition, but in the end I changed it to 0.4

copy_change_red_banner.mov_medium.mov
copy_change_red_banner.mov_small.mov

@Ciabas Ciabas requested a review from bosko-m June 4, 2025 13:30
@Ciabas Ciabas self-assigned this Jun 4, 2025
@Ciabas Ciabas requested review from MSzalowski and Ryun1 as code owners June 4, 2025 13:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

✅ All checks succeeded

@Ciabas Ciabas marked this pull request as draft June 4, 2025 13:33
@Ciabas Ciabas removed the request for review from MSzalowski June 4, 2025 13:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3728-update-red-banner-copy-and-behavior-on-govtool branch from 43191d3 to 59cc7d9 Compare June 4, 2025 14:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

✅ All checks succeeded

@Ciabas Ciabas marked this pull request as ready for review June 4, 2025 14:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

✅ All checks succeeded

@bosko-m bosko-m merged commit 2459cbf into develop Jun 4, 2025
8 checks passed
@bosko-m bosko-m deleted the 3728-update-red-banner-copy-and-behavior-on-govtool branch June 4, 2025 14:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

✅ All checks succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants