Skip to content

Fix: proposal sorting test#3732

Merged
kneerose merged 4 commits into
developfrom
fix/proposal-sorting-test
Jun 9, 2025
Merged

Fix: proposal sorting test#3732
kneerose merged 4 commits into
developfrom
fix/proposal-sorting-test

Conversation

@kneerose
Copy link
Copy Markdown
Contributor

@kneerose kneerose commented Jun 5, 2025

List of changes

  • Use content attributes "created at" for proposal date filter
  • Ignore the space in the name comparison
  • Show validation error message if it fails on sorting
  • Increase the timeout for the in-progress status of the transaction

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from MSzalowski as a code owner June 5, 2025 07:09
@kneerose kneerose requested a review from mesudip June 5, 2025 07:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2025

✅ All checks succeeded

@kneerose kneerose merged commit 5f6bf60 into develop Jun 9, 2025
7 of 11 checks passed
@kneerose kneerose deleted the fix/proposal-sorting-test branch June 9, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants