Skip to content

Fix: proposal search case and unfocus input #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kneerose merged 3 commits into from
Jun 10, 2025
Merged

Fix: proposal search case and unfocus input #3740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e988d13
fix: make proposal title search case-insensitive
kneerose Jun 9, 2025
6828985
fix: ensure proposal cards are visible in governance actions test
kneerose Jun 9, 2025
8bea9a1
fix: add keyboard tab for focus after input
kneerose Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/govtool-frontend/playwright/lib/forms/dRepForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ export default class DRepForm {
await this.identityReferenceFirstDescriptionInput.fill(
dRepInfo.identityReferenceLinks[0].description
);

await this.form.keyboard.press("Tab");
}

async validateForm(dRepInfo: IDRepInfo) {
Expand Down
1 change: 1 addition & 0 deletions tests/govtool-frontend/playwright/tests/4-proposal-visibility/proposalVisibility.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ test("4H. Should verify none of the displayed governance actions have expired",
async () => {
const proposalCards = await govActionsPage.getAllProposals();
for (const proposalCard of proposalCards) {
await expect(proposalCard).toBeVisible();
const expiryDateEl = proposalCard.getByTestId("expiry-date");
const expiryDateTxt = await expiryDateEl.innerText();
const expiryDate = extractExpiryDateFromText(expiryDateTxt);
Expand Down
4 changes: 3 additions & 1 deletion tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,9 @@ test("8C. Should search the list of proposed governance actions.", async ({
const proposalTitle = await proposalCard
.locator('[data-testid^="proposal-"][data-testid$="-title"]')
.innerText();
expect(proposalTitle.trim()).toContain(proposalName.trim());
expect(proposalTitle.toLowerCase().trim()).toContain(
proposalName.toLowerCase().trim()
);
}
},
{
Expand Down