Skip to content

(fix#3615) fix invalid css file for markdown tables #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ciabas merged 1 commit into from
Jul 1, 2025
Merged

(fix#3615) fix invalid css file for markdown tables #3863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 21 additions & 23 deletions govtool/frontend/src/components/molecules/tableMarkdown.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,26 @@
.markdown {
Copy link
Copy Markdown
Contributor

@bosko-m bosko-m Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ciabas Are you sure that Outcomes pillar doesnt need this class? Can you please check?

Copy link
Copy Markdown
Contributor Author

@Ciabas Ciabas Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://preview.gov.tools/outcomes/governance_actions/a5a65bbb5af1b58226e0bbcb19eb0a1961da6c7f5fd7e4d1a6a74bfd516c9cd9#0

https://gov.tools/outcomes/governance_actions/60ed6ab43c840ff888a8af30a1ed27b41e9f4a91a89822b2b63d1bfc52aeec45#0

I'm not seeing any "markdown" class in there. This file is completely omitted during the build phase since it's not a valid .css file.

Copy link
Copy Markdown
Contributor Author

@Ciabas Ciabas Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it back to the original implementation with .markdown, but only fix the invalid file.

& table {
display: block;
overflow-x: auto;
margin: 32px 0;
border-spacing: 0;
border-collapse: collapse;
max-width: 100%;
.markdown table {
display: block;
overflow-x: auto;
margin: 32px 0;
border-spacing: 0;
border-collapse: collapse;
max-width: 100%;
}

& thead {
background-color: #d6e2ff80;
}
.markdown thead {
background-color: #d6e2ff80;
}

& th,
& td {
padding: 6px 13px;
border: 1px solid #d6e2ff;
}
.markdown th,
.markdown td {
padding: 6px 13px;
border: 1px solid #d6e2ff;
}

& td > :last-child {
margin-bottom: 0;
}
.markdown td > :last-child {
margin-bottom: 0;
}

& tr:nth-child(2n) {
background-color: #d6e2ff80;
}
}
.markdown tr:nth-child(2n) {
background-color: #d6e2ff80;
}