(fix#3132): change titles from Governance Actions to Live Voting#3865
Conversation
|
✅ All checks succeeded |
|
✅ All checks succeeded |
1 similar comment
|
✅ All checks succeeded |
| editDrepMetadata: "/edit_drep", | ||
| error: "/error", | ||
| faqs: "/faqs", | ||
| governanceActions: "/governance_actions", |
There was a problem hiding this comment.
@Ciabas Cant agree with route changes, unless you tell me the old routes will redirect automatically to new ones?
Some of the GA details were socialzed, shared, so we dont want to "kill" that.
If you cant achieve backward compatibility, then routes should stay the same and just adjust pages titles accordingly.
There was a problem hiding this comment.
It was in the task description. I reverted the paths changes.
Ciabas
force-pushed
the
3132-title-wrong-on-live-voting-page
branch
from
79bc0b8 to
c57ad9f
Compare
|
✅ All checks succeeded |
1 similar comment
|
✅ All checks succeeded |
| export const OUTCOMES_PATHS = { | ||
| governanceActionsOutcomes: "/outcomes", | ||
| governanceActionOutcomes: "/outcomes/governance_actions/:id", | ||
| governanceActionsLiveVoting: "/connected/governance_actions", |
There was a problem hiding this comment.
I removed that since it a duplicate of other path.
|
✅ All checks succeeded |
|
@Ciabas |
|
@Ciabas |
|
@Ciabas |
2 participants
List of changes
Checklist
Changes: