Skip to content

(fix#3881) Add SPOs not voted percentage value to gov actions #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ciabas merged 1 commit into from
Jul 15, 2025
Merged

(fix#3881) Add SPOs not voted percentage value to gov actions #3880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions govtool/frontend/src/components/molecules/VotesSubmitted.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ export const VotesSubmitted = ({
dRepAbstainVotes + (networkTotalStake?.alwaysAbstainVotingPower ?? 0);

// TODO: Move this logic to backend

// DRep votes
const dRepYesVotesPercentage = totalStakeControlledByDReps
? (dRepYesVotes / totalStakeControlledByDReps) * 100
: undefined;
Expand All @@ -108,33 +110,45 @@ export const VotesSubmitted = ({
const dRepNotVotedVotesPercentage =
100 - (dRepYesVotesPercentage ?? 0) - (dRepNoVotesPercentage ?? 0);

// SPO/Pool votes
const poolYesVotesPercentage =
typeof poolYesVotes === "number" &&
typeof networkTotalStake?.totalStakeControlledBySPOs === "number" &&
networkTotalStake.totalStakeControlledBySPOs > 0
? (poolYesVotes / networkTotalStake.totalStakeControlledBySPOs) * 100
: undefined;

const poolNoVotesPercentage =
typeof poolNoVotes === "number" &&
typeof networkTotalStake?.totalStakeControlledBySPOs === "number" &&
networkTotalStake.totalStakeControlledBySPOs > 0
? (poolNoVotes / networkTotalStake.totalStakeControlledBySPOs) * 100
: undefined;

const poolNotVotedVotes =
typeof networkTotalStake?.totalStakeControlledBySPOs === "number"
? networkTotalStake.totalStakeControlledBySPOs -
(poolYesVotes + poolNoVotes + poolAbstainVotes)
: undefined;

const poolNotVotedVotesPercentage =
100 -
(typeof poolYesVotesPercentage === "number" ? poolYesVotesPercentage : 0) -
(typeof poolNoVotesPercentage === "number" ? poolNoVotesPercentage : 0);

// Constitutional Commission votes
const ccYesVotesPercentage = noOfCommitteeMembers
? (ccYesVotes / noOfCommitteeMembers) * 100
: undefined;
const ccNoVotesPercentage = noOfCommitteeMembers

const ccNoVotesPercentage = noOfCommitteeMembers
? (ccNoVotes / noOfCommitteeMembers) * 100
: undefined;
const ccNotVotedVotes =

const ccNotVotedVotes =
noOfCommitteeMembers - ccYesVotes - ccNoVotes - ccAbstainVotes;
const ccNotVotedVotesPercentage =

const ccNotVotedVotesPercentage =
100 - (ccYesVotesPercentage ?? 0) - (ccNoVotesPercentage ?? 0);

return (
Expand Down Expand Up @@ -209,6 +223,7 @@ export const VotesSubmitted = ({
noVotesPercentage={poolNoVotesPercentage}
abstainVotes={poolAbstainVotes}
notVotedVotes={poolNotVotedVotes}
notVotedPercentage={poolNotVotedVotesPercentage}
threshold={
(() => {
const votingThresholdKey = getGovActionVotingThresholdKey({
Expand Down