Skip to content

(fix#3954): Incorrect Display of New Committee Parameters in Governance Action Details#3981

Merged
Ciabas merged 1 commit into
developfrom
3954-incorrect-display-of-new-committee-parameters-in-governance-action-details
Jul 31, 2025
Merged

(fix#3954): Incorrect Display of New Committee Parameters in Governance Action Details#3981
Ciabas merged 1 commit into
developfrom
3954-incorrect-display-of-new-committee-parameters-in-governance-action-details

Conversation

@Ciabas
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas commented Jul 29, 2025 •
edited
Loading

List of changes

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Changes

image

https://p80-z78acf3c2-zded6a792-gtw.z937eb260.rustrocks.fr/outcomes/governance_actions/77cc6292907df30d4340aa389dda453ea03aae1aa18a71c1856ac10851498188#0
image

Additional Context

The values to be added and removed are constitutional committee cold credentials, some of these credentials are script-based some of these are key-based when encoded like this (Bech32) following the CIP-129 standard it is hard to tell which are script-based and which are >key-based we can use govIdInspector to inspect these and check them

To determine which type of credential is being using check govIdInspector which is an implementation of CIP-129
where for an id the tool will say Type: SCRIPT for script-based and Type: ADDRESS for key-based
or alternatively for CC cold credentials, it is 12 prefix to hex encoded key hash AND 13 prefix to hex encoded script hash

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3954-incorrect-display-of-new-committee-parameters-in-governance-action-details branch from 6a08757 to 20e8303 Compare July 29, 2025 08:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

❌ Docker Image Scan (Dockle) failed

No output

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3954-incorrect-display-of-new-committee-parameters-in-governance-action-details branch from 6140d06 to fe0563c Compare July 29, 2025 11:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

❌ Docker Image Scan (Dockle) failed

No output

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3954-incorrect-display-of-new-committee-parameters-in-governance-action-details branch from fe0563c to bcdb3ea Compare July 29, 2025 11:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

❌ Docker Image Scan (Dockle) failed

No output

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3954-incorrect-display-of-new-committee-parameters-in-governance-action-details branch from bcdb3ea to 20e8303 Compare July 29, 2025 12:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

5 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3954-incorrect-display-of-new-committee-parameters-in-governance-action-details branch from 90c8896 to c30322a Compare July 30, 2025 20:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 30, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 30, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 30, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3954-incorrect-display-of-new-committee-parameters-in-governance-action-details branch from c30322a to 55cf5dd Compare July 31, 2025 07:39
@Ciabas Ciabas requested a review from bosko-m July 31, 2025 07:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 31, 2025

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 31, 2025

✅ All checks succeeded

@Ciabas Ciabas marked this pull request as ready for review July 31, 2025 07:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 31, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3954-incorrect-display-of-new-committee-parameters-in-governance-action-details branch from 55cf5dd to 5973c3b Compare July 31, 2025 08:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 31, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 31, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 31, 2025

✅ All checks succeeded

@Ciabas Ciabas merged commit 90ddbe5 into develop Jul 31, 2025
10 checks passed
@Ciabas Ciabas deleted the 3954-incorrect-display-of-new-committee-parameters-in-governance-action-details branch July 31, 2025 09:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 31, 2025

@Ciabas
This PR is in the tag: develop-90ddbe50c57fcecea8485713a2c7a56b35419749 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 31, 2025

@Ciabas
This PR is in the tag: develop-90ddbe50c57fcecea8485713a2c7a56b35419749 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 31, 2025

@Ciabas
This PR is in the tag: develop-90ddbe50c57fcecea8485713a2c7a56b35419749 , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@placek placek Awaiting requested review from placek

@MSzalowski MSzalowski Awaiting requested review from MSzalowski

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

1 more reviewer

@bosko-m bosko-m bosko-m approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ciabas @bosko-m