Skip to content

Search stops working after entering GA details and going back to Live Voting #4020 #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bosko-m merged 1 commit into from
Aug 12, 2025
Merged

Search stops working after entering GA details and going back to Live Voting #4020 #4026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions govtool/frontend/src/context/dataActionsBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,18 +68,32 @@ const DataActionsBarProvider: FC<ProviderProps> = ({ children }) => {
isAdjusting.current = false;
}, []);

const gADetailsPathnameRegexp = /^.*\/governance_actions\/[a-fA-F0-9]{64}$/;
const userMovedToDifferentAppArea =
pathname !== lastPath &&
(!pathname.startsWith(lastPath) || lastPath === "" || lastPath === "/");
const userOpenedGADetails = gADetailsPathnameRegexp.test(pathname);
const userOpenedGADetailsFromCategoryPage =
lastPath.includes("governance_actions/category") &&
pathname.includes("governance_actions/");
userOpenedGADetails &&
lastPath.includes("governance_actions/category");
const userMovedFromGAListToCategoryPage =
lastPath.endsWith("governance_actions") &&
pathname.includes("governance_actions/category");
const userMovedFromGADetailsToListOrCategoryPage =
(gADetailsPathnameRegexp.test(lastPath) &&
pathname.includes("governance_actions")) ||
pathname.includes("governance_actions/category");

useEffect(() => {
isAdjusting.current = true;
if (userOpenedGADetails) {
return;
}

if (userMovedFromGADetailsToListOrCategoryPage && debouncedSearchText.length > 0) {
isAdjusting.current = false;
return;
}

if (
(!pathname.includes("drep_directory") &&
Expand All @@ -93,7 +107,7 @@ const DataActionsBarProvider: FC<ProviderProps> = ({ children }) => {

useEffect(() => {
setLastPath(pathname);
}, [searchText, chosenFilters, chosenSorting]);
}, [pathname, searchText, chosenFilters, chosenSorting]);

const contextValue = useMemo(
() => ({
Expand Down