Skip to content

Fix : Update Random Option to Activity Option in DRep List Related Tests#4055

Merged
kneerose merged 1 commit into
IntersectMBO:developfrom
JosephRana11:develop
Sep 4, 2025
Merged

Fix : Update Random Option to Activity Option in DRep List Related Tests#4055
kneerose merged 1 commit into
IntersectMBO:developfrom
JosephRana11:develop

Conversation

@JosephRana11
Copy link
Copy Markdown
Contributor

@JosephRana11 JosephRana11 commented Sep 4, 2025 •
edited
Loading

List of changes

  • Updated Random option to Activity option and tests where it was being used.
  • Marked skip to some now deprecated random sort dependent tests.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose self-requested a review September 4, 2025 08:53
kneerose
kneerose approved these changes Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kneerose kneerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kneerose kneerose merged commit 86ed7ba into IntersectMBO:develop Sep 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

@JosephRana11
This PR is in the tag: develop-86ed7ba632c0ccc6c0a4ff2f9df1e8023be3b4bd , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

@JosephRana11
This PR is in the tag: develop-86ed7ba632c0ccc6c0a4ff2f9df1e8023be3b4bd , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

@JosephRana11
This PR is in the tag: develop-86ed7ba632c0ccc6c0a4ff2f9df1e8023be3b4bd , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MSzalowski MSzalowski Awaiting requested review from MSzalowski

1 more reviewer

@kneerose kneerose kneerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JosephRana11 @kneerose