Skip to content

fix drep vote calculation for proposal display tests #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kneerose merged 1 commit into from
Sep 5, 2025
Merged

fix drep vote calculation for proposal display tests #4057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tests/govtool-frontend/playwright/lib/pages/outcomeDetailsPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export default class OutcomeDetailsPage {
isLoggedIn = false
) {
await Promise.all(
Object.keys(outcomeType).map(async (filterKey) => {
Object.entries(outcomeType).map(async ([filterKey, filterValue]) => {
const outcomePage = new OutComesPage(this.page);
const {
govActionDetailsPage,
Expand All @@ -106,6 +106,7 @@ export default class OutcomeDetailsPage {
isLoggedIn
);


if (!govActionDetailsPage) {
return;
}
Expand All @@ -120,6 +121,11 @@ export default class OutcomeDetailsPage {
metricsResponse
);

const metricsResponseJson = await metricsResponse.json();
const totalStakeControlledByNoConfidence = Number(metricsResponseJson.always_no_confidence_voting_power)
const dRepYesVotes = filterValue === outcomeType.NoConfidence ? Number(proposalToCheck.yes_votes) + totalStakeControlledByNoConfidence : Number(proposalToCheck.yes_votes);
const dRepNoVotes = filterValue != outcomeType.NoConfidence ? Number(proposalToCheck.no_votes) + totalStakeControlledByNoConfidence : Number(proposalToCheck.no_votes) ;

const currentPageUrl = govActionDetailsPage.currentPage.url();

// check dRep votes
Expand All @@ -134,7 +140,7 @@ export default class OutcomeDetailsPage {
message: `DRep "Yes" voting power checked for ${currentPageUrl}`,
}
).toHaveText(
`Yes${formatWithThousandSeparator(proposalToCheck.yes_votes, false)}`,
`Yes${formatWithThousandSeparator(dRepYesVotes, false)}`,
{
timeout: 60_000,
}
Expand Down Expand Up @@ -177,7 +183,7 @@ export default class OutcomeDetailsPage {
message: `DRep "No" voting power checked for ${currentPageUrl}`,
}
).toHaveText(
`No${formatWithThousandSeparator(proposalToCheck.no_votes, false)}`
`No${formatWithThousandSeparator(dRepNoVotes, false)}`
); //BUG missing testIds
}

Expand Down