generated from Intery/dpy-cmdClient-template
-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Labels
bugSomething isn't workingSomething isn't workingbugscope:minorBug doesn't affect most users or featuresBug doesn't affect most users or featuresdifficulty:easyStraightforward, minimal structural knowledge neededStraightforward, minimal structural knowledge neededgood first issueGood for newcomersGood for newcomersmodule:timer-coreTimer module core functionality (timers, subscribers, timerchannels, etc)Timer module core functionality (timers, subscribers, timerchannels, etc)
Description
If Timer.change_stage(...) throws an exception while sending the stage change message (potentially due to a Discord hiccup, but also for any other reason), the time remaining will not be updated and the Timer runloop will attempt to change stage again.
This may result in the group members being ejected from the group and large amounts of spam as the change stage messages are re-sent.
Proposed Solution
Move the active stage changing logic to the top of change_stage so that it is always guaranteed to occur, making it independent of Discord and network state.
Additionally, log exceptions that occur through change_stage rather than silence them.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingbugscope:minorBug doesn't affect most users or featuresBug doesn't affect most users or featuresdifficulty:easyStraightforward, minimal structural knowledge neededStraightforward, minimal structural knowledge neededgood first issueGood for newcomersGood for newcomersmodule:timer-coreTimer module core functionality (timers, subscribers, timerchannels, etc)Timer module core functionality (timers, subscribers, timerchannels, etc)